Huddle Single Landing Page Intro Section using FLEXBOX and CSS GRID

Community feedback

• 

  Leon Michalak•545

  @NinjaInShadePosted over 3 years ago

  I just completed this challenge myself, and you have commented a few times on my solutions, so I'd like to give some feedback which I think could improve your code and design :)

  1. Add a container (or seperate containers) so that everything is aligned at bigger screens into one area. Looking at the design, everything is contained within 1250px

  2. The background repeats on my monitor, so I'd suggest normally adding:

  background-size: cover;

  However, you have already done this, and the reason it repeats is because you made it to. The design is 800px high, so I'd perhaps atleast set a max-height to your content so the background fits nicer.

  If you check my solution, I used a flexbox column for the main 3 sections, nav, header and footer, with a justify of space-between and min-height of 800. Then I added some paddings/margins to elements (taken from the design file) and everything more or less fit inside the 800px height.

  Marked as helpful

  1

  ---

  

  Shahin NJ•1,190

  @SJ-NosratPosted over 3 years ago

  @NinjaInShade

  Yes, you're very right about it! I need to go back to this project and improve on it! I'll put your suggestions to work.

  Thanks for taking the time to provide me with feedback!

  Keep on coding!

  1

  

  Leon Michalak•545

  @NinjaInShadePosted over 3 years ago

  @shahin1987 No problem! You too :)

  0