Design comparison
Solution retrospective
Hi!
This is my second challenge here. I feel like my code (especially scss) is not clean and tidy, so feedback is very welcome and appreciated!
Community feedback
- @fraserwatPosted over 3 years ago
This looks really great. The only change visually I'd make would be to change the sizing of the
h1
element from a calculation to just a standardrem
.If you're concerned with your code being tidy, I think this is fine (e.g. your naming conventions make sense, everything seems sensibly arranged) but you could always break out the stuff in the container out into its own SCSS file if you wanted to tidy it up a bit?
1@FahrulZulPosted over 3 years agoHi, fraserwat! 👋
For the
h1
element, I'm sorry, I didn't get what you mean, if I use standardrem
, then I need to change thefont-size
on every breakpoint, so I useclamp()
function for less code.I'm glad you say it's fine, yeah, you're right, I could break some stuff into different SCSS file.
Thanks for the feedback. I really appreciate it!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord