@fraserwat
Posted
This looks really great. The only change visually I'd make would be to change the sizing of the h1 element from a calculation to just a standard rem.
If you're concerned with your code being tidy, I think this is fine (e.g. your naming conventions make sense, everything seems sensibly arranged) but you could always break out the stuff in the container out into its own SCSS file if you wanted to tidy it up a bit?
@FahrulZul
Posted
Hi, fraserwat! 👋
For the h1 element, I'm sorry, I didn't get what you mean, if I use standard rem, then I need to change the font-size on every breakpoint, so I use clamp() function for less code.
I'm glad you say it's fine, yeah, you're right, I could break some stuff into different SCSS file.
Thanks for the feedback. I really appreciate it!
