@vanzasetia
Posted
Hello there! 👋
Congratulations on finishing this challenge! 👏
Regarding the accessibility issues, you can add aria-label attribute to each anchor tag to give some text about the link. For example, if it is a Facebook icon then the value for the aria-label would be aria-label="Facebook".
I have one question, each issue has the "Learn More" link. So, have you visited the site? Right there, you can get more information about the issue and how to solve the issue. 😉
I have a few suggestions for this solution.
- I would recommend making the visible
h2as theh1and then removing the visually hiddenh1. I think the currenth2can be a greath1. Also, I assume that it is the first part of the landing page. - I would not recommend hiding the attribution. The users who don't use screenreaders would have no idea that there are links to the Frontend Mentor challenge page and your profile.
I hope this helps! Happy coding! 😁
Marked as helpful
@Ax-cd
Posted
@vanzasetia Hello! Thank you!
I actually visited the site! I truly don't know how I could miss the information; but thank you for redirecting me to it!
I took into consideration your suggestions when I updated my solution, so thank you again for the feedback! :D
@vanzasetia
Posted
@Ax-cd I took a look at the updated source code and everything looked great to me! Good job on improving the solution! 👍
Keep it up! 😉
@Ax-cd
Posted
@vanzasetia Thank you! :D
