Vanza Setia• 27,795
@vanzasetia
Posted
Greetings, Archit Kakkar! 👋
Nice work on this challenge! 👍
I have a few suggestions for this solution.
- The logo's alternative text should be the company's name. Also, alternative text should not have the word is related to "image". The semantic meaning of the
imgelement is enough to tell the screenreaders that it is an image. - Wrap each social media icon with an anchor tag. Also, add
aria-labelto give text content to the anchor tag so the link element is accessible by screenreader users. - I highly recommend writing the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
I hope this helps! 😁
Marked as helpful
0
Archit Kakkar• 140
@architkakkar
Posted
Hi @vanzasetia ,
This was really helpful! Will surely implement your suggestions in my upcoming projects.
Cheers, Archit.
0
Vanza Setia• 27,795
@vanzasetia
Posted
@architkakkar
Happy to hear that was helpful! 😊
It's best the issues that are available on this project first before moving on to the next project. It's because fixing bugs and/or improving code is one of the skills that you will need as a developer. 😄
0
