Huddle landing page with single section

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there @Hassiai 👋! Here are some suggestions to help improve your code:

  Being that you are a mentor that is constantly on the wall of fame , you should not be making this types of errors.

  • The header ⚠️ should be outside the main and why is the logo's alt tag blank? The logo is the arguably most importance component of a site, so it should never have a blank alt tag, Instead if should state the company's name.

  • This <div class="container"> is not needed ⚠️.

  • The illustration serves no other purpose than to be decorative ⚠️; It adds no value to whatsoever. So its alt tag should be blank.

  • This <button> Register</button> should definitely be an anchor element ⚠️, so your user are directed to a proper sign-up page.

  • The social media icons, should be built ⚠️ with a unordered list element. To space them out use gap instead of margin.

  • Why are not using ⚠️ variables for, at minimum, your colors? This helps keep your colors organized and easier to change if needed down the line.

  • Your use of responsive units is inconsistent ⚠️. For example

  header {
      margin-top: 2em;
      margin-bottom: 3em;
  }
  

  @media (min-width:600px) {
      header {
          margin-bottom: 5rem;
          margin-top: 2.5rem;
      }
  

  • The background image on desktop layout should be background-size: cover; ⚠️ not `contain.

  • Adding ⚠️ some transition to your hover elements will give the smooth transition from default to hover color.

  • Your media query needs to start a lot later ⚠️, since currently the text gets all bunched up and stretches vertically.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  5

  ---

  

  Ozioma Egole•90

  @Ozioma45Posted almost 2 years ago

  @vcarames wow!! Sorry am just new to this platform, but with this much observation, surely i really need to up my game. Now i know that i know nothing about coding/programming, I hope to learn from all of the gurus in here starting from you and would really appreciate it if you would look at some of my solutions and give your corrections and feedback.

  0