Submitted almost 5 years ago
Huddle landing page with single introductory section using grid css
@fadzrinmadu
Design comparison
SolutionDesign
Solution retrospective
please review my code and let me know what i need to improve. thanks in advance
Community feedback
- @mattstuddertPosted almost 5 years ago
Nice work Muhammad! The main pointers I've got are:
- You're currently only setting the mobile background image. So I'd add the desktop version in for your desktop layout and also set
background-size: cover;
so that it stretches the width of the screen. - Your "Register" anchor tag doesn't need
role="button"
, as it would just be a regular clickable link if this were a fully-functioning website.
Keep up the great work!
0@fadzrinmaduPosted almost 5 years ago@mattstuddert hmm i forget some details. thanks for the comments i will fix it
0 - You're currently only setting the mobile background image. So I'd add the desktop version in for your desktop layout and also set
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord