Huddle landing page with single introductory section using Flexbox
Design comparison
Solution retrospective
This is my solution to the Huddle landing page challenge. I would love to hear your feedback on what I could improve.
Community feedback
- @grace-snowPosted over 1 year ago
This looks pretty good but there are a few areas that could be improved. (No 4 and 5 are the super important ones)
- If including a reset (very good to do) include it at the start of your actual css. Calling an additional externally hosted file is bad for performance
- I can't see a max width in rem on the components anywhere, so imagine this will start to look bad on really big screens (not tested this though as I'm away from my computer)
- 0.75rem equates to only 12 pixels. That is extremely small for text and concerns me, I cannot read text that small on my mobile for example
- Hover and focus visible styles serve different purposes and should look different. It's a WCAG requirement for focus visible to include noticeable outlines. I recommend you use a thick solid outline in a contrasting color for your focus visible styles on interactive elements
- You must change the aria labels on those social links. They should only say the name of the platform and that it opens in a new tab like "Facebook (opens in a new tab)". This is essential otherwise voice control users will be unable to activate these links
Marked as helpful1@WesselKonstantinovPosted over 1 year ago@grace-snow Thank you very much for your feedback! I will definitely work on the points you mentioned.
0@WesselKonstantinovPosted over 1 year ago@grace-snow I went back to my code and made a few changes based on the feedback you provided. Refactoring really is a great exercise in itself and I'm quite pleased with the result. Thank you once again for your feedback and I look forward to hearing from you again 😃.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord