@vanzasetia
Posted
Hi!
Regarding the social media icons, I prefer the original design. Using the black color for the social media icons while all the other text is white is not appropriate. That's my opinion. I am not a designer. So, feel free to take my suggestion if you want.
Some suggestions:
- Why are you adding
aria-hidden="true"
to theimg
that has alternative text? - Logo is an important content of the page. It's not decorative. So, it should not have
aria-hidden="true"
attribute. - Also, the alternative text for the logo should be the company name (
alt="Huddle"
). Currently, people can think that the site is a website for a Logo company. - Never limit the height of the
body
element. It will not allow the users to scroll the page if the page content needs moreheight
. You can see the issue by looking at the site on a mobile landscape view. So, my recommendation is to usemin-height
instead. - Use the
em
unit for media queries. It adapts when the users change their font size setting. Here are some references.
I hope this helps!
Marked as helpful
@nt-squared
Posted
Hi 👋 Your comment is always helpful, especially regarding accessibility. I feel very grateful for that. Thanks a lot!
@vanzasetia
Posted
@nt-squared Sure! 👍