Design comparison
SolutionDesign
Solution retrospective
any advice are appreciated. thanks.
Community feedback
- @ValeriaMontoyaPosted almost 3 years ago
You did a great job, it looks amazing. My only tip is that you can separate the CSS on different files, for example create a mobile.css and desktop.css files and add something like this in the HTML head: <link rel="stylesheet" href="mobile.css" />
<link rel="stylesheet" href="desktop.css" media="screen and (min-width: 1440px)"/>1 - @brodiewebdtPosted almost 3 years ago
This looks very good. The only suggestion I would make is to add a line-height of about 1.1 or 1.2 to the H1 at desktop resolution. The lines are a little far apart. You want to add line-height to body copy and smaller text and reduce the line-height at larger font sizes. Great job.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord