Huddle landing page with single introductory section (Flexbox, Grid)

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hi Patrick, I don't think you over complicated it at all! You've done a really good job. What do you think you did to over complicate it? Here is some feedback after taking a look at your code:

  • I would avoid using the @import statement in CSS as it slows down the loading time of your CSS file. Each statement blocks the loading time, so it's best to just use a single file. Or you could use a CSS pre-processor like SASS and use import statements to build a single CSS file.
  • The "Register" call-to-action should be an anchor tag, as it would be a clickable link that would navigate to another page if this were a proper site. Also, the social icons should be wrapped in anchor tags, as they would be clickable.

  I hope that helps. Keep up the great work! 👍

  1

  ---

  

  Patrick Touchette•355

  @patricktouchettePosted almost 5 years ago

  @mattstuddert Hi Matt, it surprised me how many lines of CSS I ended up with. Looking at the design I thought it would be much less code! Hence why I thought I over complicated it.

  I will look into using SASS for my next submissions since I really like having my css split up into multiple files.

  Good point for the CTA and social links, I will fix those.

  Thanks!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @patricktouchette SASS is a great way to help write less code. I'm sure you'll like it!

  0