@vanzasetia
Posted
Hi, Tenzin! 👋
Congratulations on finishing another challenge! 👏 It has been a while since my last feedback on your solution. 😄
Anyway, some recommendations from me.
- I recommend removing the
max-width: 1440px;from thebodyelement. There's no need to limit the width of thebodyelement. Treat thebodyelement as the page of the site. What I recommend doing is to limit the width of the elements inside thebodyelement. - The alternative text for the logo should be "Huddle". This way, the screenreader users can know that they are on the Huddle website.
- I would make the register button as a link instead of a button element. As a user, I would think that after I click the button, I will get navigated to the register page. So, what do you think will happen after the users click the button? Regardless of what you decide later, always specify the
typeof thebutton. It will prevent the button from behaving unexpectedly. - Each of the social media icons should be wrapped by an anchor tag. They have interactivity so they need to be wrapped with interactive elements.
That's it! I hope this helps! Happy coding! 😄
Marked as helpful
@vanzasetia
Posted
@lekdup
One more suggestion I have is to keep the specificity of the CSS as low as possible. This was the mistake that I made when I started using Sass. I nested too much and as a result, when I came back again, I wasn't able to understand the code that I wrote. So, I would recommend only nesting when you want to style pseudo-elements, pseudo-classes (:hover, :focus, etc) and @media queries. It's a good practice to keep the CSS specificity as low and flat as possible. High specificity will make your stylesheet hard to maintain.
Marked as helpful
@lekdup
Posted
@vanzasetia Hello Venza, Thank you very much for your time and helping me out! your feedbacks are always very helpful for me and always get to learn new things from you. thanks again i hope to see your feedbacks on my new challenges.
