Huddle Landing Page With Single Introductory Section

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • For the alt attribute of the logo, use the company name as the alt description. The words "images" or "logo" are not necessary.

  • The social media icons should be links (<a>) and contain the <i> element inside.

  • Use rem or em instead of pixels for font-size, this way the font size will adapt based on the user's browser settings.

  • Add two dots instead of one to display the image correctly, as the CSS file is inside a folder. For example: background-image: url(../images/bg-desktop.svg);

  I hope you find it useful! 😄

  Happy coding!

  4
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  To make the background-image of the body visible, add ./ to the beginning of the url value url(./images/bg-mobile.svg) instead of url(images/bg-mobile.svg).

  To center .card on the page using flexbox, replace the height in the body with min-height: 100vh.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0