Frontend Mentor | Huddle landing page with single introductory section coding challenge solution

@VCarames

Posted almost 2 years ago

Hey @aheduardo5, some suggestions to improve you code:

Logo needs to wrapped in a Header Element.
The Alt Tag in the logo needs to be improve. Arguably the logo is the most important image in you page. The description needs to tell the user the company name and what they do.
To fix your background, add the following to the Body Element:


body {
  min-height: 100vh;
  background-size: cover;
  background-position: center;
}

The social media icons are not decorative they serve a purpose. The need be implemented with an Image Element and the Alt Tag should state that its a [social media] logo that will direct the user to a the companies [social media] site.
Remove the width from the Main Element this will fix your layout issue in mobile view.
While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.

More info:

To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

More Info:

Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

Happy Coding!

Marked as helpful

Huddle landing page with single introductory section