Design comparison
SolutionDesign
Solution retrospective
Please feel free to leave feedback, I'd appreciate it. Thank you!
Community feedback
- @shashiloPosted over 4 years ago
Hey Mai. This looks really good. It's good seeing you using BEM as your class naming convention. Here's a list of improvements I would recommend:
- Container the design at 1440px based off the style guide.
- Semantically, you the logo should be in the
<header>
and the content should be in<main>
. - Pay attention to the details. Your font weight, font size, line height, etc. is a tad off from the design.
- For your linked items, add a hover state and a pointer cursor. This will increase your UX for the user.
0@maihuynh94Posted over 4 years ago@shashilo Thanks so much for your feedback! I'll take notes.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord