Huddle Landing Page with HTML, CSS, Flexbox & Sass

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey, nicoleanalisecox! 👋

  Good job on this challenge! 👏 Kudos for trying out Sass! 👍

  In addition to RayaneBengaoui's helpful feedback, one or two things I'd like to suggest are,

  • Turning the social media tags in the footer of the page into actual links using the anchor tag.
  • Giving the various elements of the page fixed margin/padding values so that the space between them is more consistent across screen sizes and there's never too little/much room around them at any given point.
  • Adding min-height: 100vh and background-size: cover to the body to make sure it is always at least as hight as the viewport and the background image covers the entire screen.

  Hope those tips help. 🙂 Keep coding (and happy coding, too)! 😁

  1

  ---

  

  maya•60

  @nicoleanalisecoxPosted over 3 years ago

  Really helpful suggestions, thank you ApplePieGiraffe!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @nicoleanalisecox

  You're welcome! 👍

  One more thing that might help is if you add a max-width to the description that appears under the heading in the tablet/mobile layout (so that it isn't too wide when the layout first changes from desktop to mobile). 😉

  Oh, and hey, if you found these tips helpful, an upvote would be appreciated! ;)

  1

  

  maya•60

  @nicoleanalisecoxPosted over 3 years ago

  @ApplePieGiraffe oops! Awesome, thank you! :)

  1
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello nicoleanalisecox,

  Congrats for the challenge ! Almost pixel perfect 🙂

  I'd like to suggest :

  • Use more semantic HTML tags. Instead of using only divs you could use tags such as <main> and <aside> to make your code simpler to read.

  • Instead of using @import with SASS, it's recommended to use @use because the first one is now deprecated. You can find more information on the SASS official documentation

  • You could add a transition effect on your button to make the hover smoother. For example transition : all 0.5s ease on your button could be a start.

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  

  maya•60

  @nicoleanalisecoxPosted over 3 years ago

  Thank you for your useful feedback Rayane!

  0