Huddle landing page with HTML and CSS

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Heyo,

  Awesome job on this one. Looks very good on all screen sizes (apart from the extra purple background colour which hurts my eyes a bit, if I'm honest :D). I'd like to add a few things where you could improve this a bit:

  1. Wrapping buttons in an a tag is incorrect. You either go with a link or a button, you can't do both :) They do slightly different things, in this case, just using a button will do!

  2. The div for your social links could be swapped for a ul, it's considered a list. Your links also need to have an aria-label, as they don't have any visible text-description.

  3. For your logo alt text, you don't need to specify it's a logo (it's an image element so it's sort of self-explanatory), "Huddle." would be a better alt for it.

  Apart from the above mentioned things you did really well! I remember it was kinda tricky to make it look good on all screen sizes when I was doing this challenge so well done. :)

  Marked as helpful

  1

  ---

  

  Mario•130

  @ohmymarioPosted almost 3 years ago

  @FluffyKas Thanks for looking over my code!

  Sorry about the purple I forgot to take it out. I was using it as a visual indicator that I was at the right breakpoint. I'll be changing it to the the original design.

  I appreciate all your advice and will be implementing it all😀

  0