Design comparison
Solution retrospective
My first solution on Frontend mentor, feedback needed please.
Community feedback
- Account deleted
Hey. I see some responsive issues that are causing a horizontal overflow.
-
Instead of having a fixed width of
400px
for the illustration, make it 100% of its available space -
don't use those fixed x-margins on mobile, leave it only for tablet and desktop
I'd also suggest that you start your designs from mobile to desktop using
min-width
instead ofmax-width
in the media-queries because is easier to scale and you won't end up having responsive issues.Lastly, I would suggest that you use more semantic elements in the HTML (for instance, you could use
<header>
instead of<div id="logo">
,<main>
instead ofdiv id="main">
or<section>
for thematic grouping of content)Let me know if you have doubts about it.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord