Huddle landing page with flexbox for responsive layouts

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  Hey @Fajarhdyt great work on this one! The site looks good and responds well at all breakpoints! Here's some (very) small points to consider:

  1. Every input needs a label so don't forget to always add one. If you don't want it to appear you can always hide it so it doesn't show up in the design itself. Here's a nice article on different techniques: https://webaim.org/techniques/css/invisiblecontent/ (check out the bit on Absolutely positioning off screen about half way down).

  2. I think you have missed a few links in your footer? I think that the icons should appear as links, and the email should probably also be clickable there too? Also in this section, the input looks a bit wide as we approach your breakpoint, perhaps a smaller max-width might solve this?

  More generally, you might want to look into 'utility classes' I was a bit scared by this but basically it's just a class you add to an element and it does the same thing everywhere you add it. It's helps with consistency and reduces the amount of CSS you need to write.

  In this case for example, you could have had a flex utility class the adjusted the direction etc and added that in your HTML, same for the padding and margin - it's worth looking into and an approach that has really helped me.

  But the page looks great. I really like what you have done here. Keep up the good work!

  2

  ---

  

  Fajar Hidayat•165

  @fajarhidayattPosted over 3 years ago

  hi @dwhenson. Thank you very much for the feedback you gave me, it was very helpful. I will correct some mistakes I made. and why does each input need a label? Is the label really important? especially in this case the label is not needed.

  1

  

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  @Fajarhdyt it’s really to help with accessibility, but it can also be helpful to expand the clickable area in the case of checkboxes and radio buttons. Here’s a helpful article https://www.coolfields.co.uk/2011/04/accessible-forms-should-every-input-have-a-label/

  0

  

  Fajar Hidayat•165

  @fajarhidayattPosted over 3 years ago

  @dwhenson Ok I see, thanks for the information

  0