Design comparison
Solution retrospective
I know my writing code might still be bad. But I've worked hard for this. I hope you like it. Any feedback is very welcome :)
Community feedback
- @YazdunPosted about 3 years ago
Hello Yunus ! This looks great and I really like button and Icon's animations on hover ! good job on that. Here I have a quick note on your accessibility issue :
-
Each page should have at least one
main
tag which wraps the whole page content, thismain
tag must have alevel one heading
which tells what this page is about, in this casemain__heading
should be enough, Fix this and your solution would be perfect ! -
Also approach mobile first, It will save you from lot of headaches !
-
And here is useful folder structure for sass that you maybe interested in.
SIDE NOTE don't forget to generate new report after you fixed accessibility issue !
1@frontendnusPosted about 3 years ago@Yazdun Thank's for the feedback Yazdun! I''ll fixed soon thanks bro :)
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord