Huddle Landing Page with Flex-box

Community feedback

• 

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  Impressive work on the challenge @shake88junt, the page responds well to mobile & desktop 👏👏👏👏.

  A few recommendations:

  • I can't navigate the site using the keyboard only, you may want to add a focus state on buttons and links.
  • Prefer using relative units
  • Instead of <div class="main"> you can use HTML5 tags <main>.

  Otherwise, great work on the challenge.

  0

  ---

  

  Matthew Pierce•495

  @shake88juntPosted over 3 years ago

  @jmnyarega really good advice man. So I should use rem instead of em?

  0

  

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  @shake88junt I will recommend starting with rems, there is a caveat with ems. If nested, they compound and cause problems. Kevin explains better CSS em and rem explained

  1

  

  Matthew Pierce•495

  @shake88juntPosted over 3 years ago

  @jmnyarega That's really helpful, I shoul've thought of it sooner. My margins, padding and font-size are more consistent now!

  0

  

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  @shake88junt Happy to help

  0