Huddle landing page with curved sections solution
Design comparison
Solution retrospective
Hi folks, I not really satisfied with this one because the code is a bit messy but I 'll make the next one cleaner. I would be glad to hear you thoughts about the following questions.
- Usage of BEM and how it could be improved ?
- Is it ok to use more the one modifier on a block ?
- Should the logo in the footer be pure css becuase I coundn't find any svg for it project files ?
Happy coding :)
Community feedback
- @MikeBish13Posted over 3 years ago
Hey, your code looks nice and clean to me! Great job!
I'm no expert in BEM so won't comment on that, but in regards to point 3:
- Have you considered inserting the SVG code into the html as opposed to setting it as a background image on a div? That way you're able to target the SVG properties directly such as the color, which you can usually get through like so:
svg { path { fill: #ffffff; } }
Take a look at the code of the SVG and you should be able to work it out. An alternative is to copy the SVG file and change the color in the fill attribute, then use the new file as the background image in the footer.
Hope that helps!
1@MojtabaMosaviPosted over 3 years ago@MikeBish13 I didn't know that you could modify svgs, great comment thank you .
0 - Have you considered inserting the SVG code into the html as opposed to setting it as a background image on a div? That way you're able to target the SVG properties directly such as the color, which you can usually get through like so:
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord