Huddle Landing Page with Curved Sections | GRID | Flexbox
Design comparison
Solution retrospective
Hi all,
Is there a way to make the curved bg-images responsive? So you don't have to keep adding media queries everytime their hight goes out of sync.
Also has anyone got any idea how you're meant to size the gaps in the curved sections? With the figma files there is no way I can see (unless I'm missing the obvious) to get a margin / padding reference. So pretty much had to eyeball the gaps, which I'm sure won't go well lol
Any and all feedback on my work is most welcome, if you have the time.
Thanks, Nick
Community feedback
- @shashreesamuelPosted over 2 years ago
Good job with this challenge, keep up the good work.
In terms of your accessibility issues,
-
Your form fields need a label attribute with a value.
-
Your anchor tags need text in order to be clickable.
In terms of your html validation, your css property transform requires more properties and secondly the pseudo-element
:root
does not exist.In terms of your design of the challenge
-
the paragraph below the title
Build your community with fans you will love
needs some space on the margin top probably around1.1rem
-
The footer does not have a white divider line so you might want to remove that.
I hope this helps
Cheers, Happy coding š
Marked as helpful0@NickODxyzPosted over 2 years agoHi @TheCoderGuru, thank you very much for taking the time with the feedback.
It's much appreciated.
Nick
1 -
- @NickODxyzPosted over 2 years ago
Oh come on now, when you visit the live site you see no gaps in my curves lol Or at least I don't :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord