Design comparison
SolutionDesign
Solution retrospective
All comments are welcome!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.
- The logo’s
alt tag
description needs to be improved upon ⚠️; it should state the company’s name.
- Since there is only a "logo" and single "button" and no "navigation menu" at the top of your site, there is no need ❌ for a
nav
element.
- Every site should ALWAYS have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content.
More Info: 📚
- The "1.4k+", "2.7m+" and "Newsletter" are not headings ❌, they should instead be wrapped in a
paragraph
element
- Avoid skipping heading levels ⚠️. Always start with the
h1
(which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.
More Info:📚
- The "Grow Together", "Flowing Conversations", "Your Users" and "Ready To Build Your Community?" Should all be
h2
headings. ⚠️, so they need to wrapped in aheading
element.
- The "newsletter" is not a heading ❌. It should instead be wrapped in a
paragraph
element/
- Your
email input
andbutton
needs to be wrapped inside aform
⚠️ and have a visibly hiddenlabel
attached to it for improved accessibility 📈.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful1 - @tony1610Posted almost 2 years ago
Awesome! thanks, I will start fixing all these mistakes. Question, you mention that the "Newsletter" is not a heading. However, looks like one, at least I see it like one. How I can identify the difference between a heading and a paragraph? like in this example. Thanks
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord