Design comparison
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi sommzy👋 Great job on completing this challenge! 🥳
I noticed a few areas where your solution to the challenge could be improved, and wanted to share my suggestions with you.
-
The CSS has a lot of repeated styles, it would be more efficient to group similar styles together and use class or id selectors.
-
The CSS has inconsistent use of units (px, %, vh) and it would be good to use a consistent unit throughout the styles.
-
In the
footer
styles, theheight
property is set to 500px, but it would be better to usemin-height
so that the footer can adapt to different screen sizes. -
There's no CSS reset or normalize stylesheet, it's good to have one to ensure consistent styling across different browsers.
-
The CSS selectors could be more specific and semantic, like using
.header__nav
instead ofheader
and.footer__copyright
instead offooter
to avoid conflicts with other styles.
Overall, this is a very well done solution to the challenge. Great job!
Hope I'm Helpful! 👍
Keep up the good work! 😊❤️
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord