Huddle landing page with curved sections

Community feedback

• 

  Mohammed Fakih•1,590

  @javascriptor1Posted 12 months ago

  Hi DEEPALI ,

  Excellent work. I just uploaded my solution to this challenge today. Here are my notes which I can share with you about your solution :

  1- For anchor links, always use anchor tag <a> and don't use button. Look at your code below:

  <button class="cta-button">Get Started For Free</button>

  Where does this button take the user?? No where. Buttons are used to take action like subscribe or submit a form. If you are sending the user to a link , use a with href attribute.

  2- For contact information in the footer, use the address html tag and wrap all information inside it.

  3- The color of the logo on top should be black, not dark cyan. You have to change it inline or via CSS.

  4- The hover state effect for social media icons is not correct.

  5- You have not applied any checking in JS whether an email is valid or not but relied on built-in browser checking. Do this checking in JavaScript and display the error message as required.

  6- For the main, it's supposed to wrap the main part or section of the page as per my understanding. This website is made of different sections and it's not correct to wrap everything in the main element including the footer 😊

  7- The Facebook icon is a little aligned to the left in comparison to the above section. This is very subtle and hardly noticeable. These elements are supposed to have the same padding/margin, so they are aligned perfectly on the same vertical line.

  Good luck and happy coding.

  0