Huddle Landing Page with Alternating Feature Blocks using Bootstrap

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The logo is not not decorative. Its Alt Tags should not be blank. The logo is arguably the most important image in you page. So the description should state the company name.

  • The nav should be wrapped inside a header element to improve semantics.

  • To identify the main content of your site, you will want to include the main element in your HTML code.

  • The way your are implementing the different layouts (mobile and desktop) is incorrect. You want to build your site starting with mobile first and use media queries to adjust your layout for larger screens.

  • The footer links need to be wrapped inside a nav element.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  1
• 

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  Hey Red Pangilinan, nice job and welcome!

  First things first, your solution looks really good, exactly what the design wanted.

  Your footer does look a bit over-engineered, but nothing crazy. What you can do is after you're done, open up the console and turn CSS properties on and off, if it doesn't make a difference it doesn't need to be there.

  For example, the container for your social icons has a margin bottom, even though the content are at the top anyways, you can see that turning off that property doesn't change anything.

  But don't worry about long HTML, that's the nature of a markup language. There may be some room for optimization, but you'll get there with time.

  Edit: By the way, if you want to have an easier time with naming your classes, you may want to look into BEM, or other conventions like it.

  Marked as helpful

  1

  ---

  

  Red Pangilinan•40

  @redpangilinanPosted about 2 years ago

  @sahand-masoleh Thank you for the feedback! This is actually the first time I heard about the CSS properties through console, I'll definitely check it out and try to further optimize my code or apply it into future projects.

  1

  

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  @redpangilinan Just to clarify, I meant the dev console inside the browser.

  I can see that you're a backend dev, so I'm guessing you thought I meant the terminal.

  1