Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
👾 Hey there! 👋 Here are some suggestions to help improve your code: 👾
- Do not forgot to check your FEM report, to see what is incorrect and update your code with it. Before moving on to the next challenge.
- The styling still needs some work to better match the FEM design.
- Never do this as it creates accessibility issues for users and it is outdated.
html { font-size: 62.5%; }
- For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
- Since there is only a "logo" and single "button" and no "navigation menu" at the top of your site, there is no need for a
nav
element.
- "Build The Community Your Fans Will Love" is the first heading in your site, so it should be an
h1
heading, noth2
.
- Remove the
article
elements you added, they are being used incorrectly.
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your Illustrations to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This,
<section class="footer">
, should afooter
element. Always use semantic elements when possible.
- The company info inside the
footer
needs to be wrapped inside anaddress
element. While each individual information needs to wrapped in ananchor
element.
More Info:📚
- The company directory needs to wrapped in a
nav
element and be built using theunordered list
element to create a single list. You will use the CSS propertycolumn
to style it.
More Info:📚
MDN <ul>: The Unordered List element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord