Submitted over 1 year ago
Huddle landing page with alternating feature blocks solution
@younesadjoudj
Design comparison
SolutionDesign
Solution retrospective
Hi guys! This is mys solution to the challenge "Huddle landing page with alternating feature blocks". Please any feedbacks or advices are welcome, especially with the responsive. Thank you!
Community feedback
- @ChamuMutezvaPosted over 1 year ago
Greetings Younes
Nice work , so far Younes. Here are a few things that you can have a look at:
HTML
- The logo image has a role that it plays in a site as it will be a link to the home page , hence it must have an anchor element as its parent.
- still in the navigation section, the
<button class="button">Try It Free</button>
, this button should also be a navigation element - its purpose here is to navigate to a section or page for the related name. Look at the difference in where to apply a button and when to use an anchor element. - the social images in the footer section are not just images but represents links to social media sites hence the images should have an anchor element as a parent.
CSS
- keep your specificity as low as possible, in the following example
header .navbar .button
, you could just use.button
- the other 2 will just increase the specificity. On large projects , that will make debugging and maintenance difficult - always start mobile first and progressively move up . I wasn't expecting
@media only screen and (max-width: 350px)
this media query at the very end. When using mobile first, usuallymin-width
is used
Marked as helpful0@younesadjoudjPosted over 1 year ago@ChamuMutezva Thank you very much for your feedbacks. I appreciate. I did some changes as like you said.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord