Huddle landing page with alternating feature blocks built with flexBox

Community feedback

• 

  Haris Shah•435

  @hariscsPosted over 3 years ago

  thanks for the feedback

  0
• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. Layout in desktop is great, resizes very well and the mobile state is great as well.

  Some suggestions would be:

  1. Your first heading tag, in the hero section, it could have been h1 instead of h2. Though you can do without it, but since we're doing proper markups, you may need h1 on a website, the top most heading.

  2. Maybe adding more padding to the different main-flex selectors. The grow, flow, users container. Adding padding like in the original so that it won't look the text touching the sides of the container.

  3. On your social media links, since the a tags does not have a text-content inside it, you can either add a span inside it and have text defining what is the a tag, something like "go to facebook", then adding a sr-only class. You can look up sr-only class definitions. You could also add aria-label property in the a tag so that it will be read by assistive tech as well.

  4. I don't know if it needs to, but on the mobile view, the footer is left-aligned but the other sections, from top going down to footer have a center align. Maybe check that out?

  Still, really good job on this^^

  0