Huddle Landing page - Pure CSS and HTML

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Since there is only a "logo" and single "button" and no "navigation menu" at the top of your site, there is no need ❌ for a nav element and it should be inside the header element.

  • The alt tag description in the logo needs to be improved upon ⚠️. The description should state the company’s name.

  • ⚠️ Remove all the article elements you added, they are being used incorrectly ❌.

  • The “illustrations/icons” serve no other purpose than to be decorative; they add no value. Their alt tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  More Info:📚

  [MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • ⚠️ The logo and company info inside the footer need to be wrapped inside an address element. While each individual information needs to wrapped in an anchor element.

  More Info:📚

  MDN Address Element

  • ⚠️ The company directory needs to wrapped in a nav element and be a single list, not two. You will use the CSS property column to style it. Each individual link needs to wrapped in an anchor element.

  More Info:📚

  MDN <ul>: The Unordered List element

  • It is best practice ✅ to use, classes for styling purposes, while using ids solely for JavaScript.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  Marked as helpful

  1

  

  Michele•150

  @michelestaffierePosted almost 2 years ago

  @vcarames Thanks for all the suggestions and looking over my project files. Ill implement your recommendations and dive into the resources you provided. Thanks!

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @michelestaffiere

  Glad I could help! 😁

  0
• 

  Leonis Ocampo Nieves•20

  @locamponievesPosted almost 2 years ago

  Great job

  1

  ---

  

  Michele•150

  @michelestaffierePosted almost 2 years ago

  @locamponieves Thank you!

  0