Responsive Landing Page

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Unless your company requires⚠️ you to use a library/framework, I strongly suggest you stay away ❌ from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library/framework, you are robbing yourself from actually learning how to code.

  • Since there is only a "logo" and single "button" and no "navigation menu" at the top of your site, there is no need ❌ for a nav element. They should instead be wrapped inside a header element.

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your "Illustrations/icons" to fully remove them from assistive technology.

  More Info:📚

  [MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • Everything at the end of the page should be wrapped inside a footer element.

  • ⚠️ The logo and company info inside the footer need to be wrapped inside an address element. While each individual information needs to wrapped in an anchor element.

  More Info:📚

  MDN Address Element

  • ⚠️ The company directory needs to wrapped in a nav element and be a single list, not two. You will use the CSS property column to style it. Each individual link needs to wrapped in an anchor element.

  • Implement a "Mobile First" approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1