Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
main
element should start here<section class="mx-2">
. Everything before that should be wrapped inside aheader
element.
- Since there is only a "logo" and single "button" and no "navigation menu" at the top of your site, there is no need for a
nav
element.
- The
alt tag
description in the logo needs to be improved upon. The description should state the company’s name.
- The “illustrations” serve no other purpose than to** be decorative**; They add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hides it from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The company info inside the
footer
needs to be wrapped inside anaddress
element. While each individual information needs to wrapped in an anchor element.
- The company "directory" needs to wrapped in a
nav
element and be a single list, not two. You will use the CSS propertycolumn
to style it.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord