Design comparison
Solution retrospective
It was fun to do this challenge. Making responsive landing page is not easy but i did best of my abilities. any feedbacks from your side is welcome and appreciated.
keep coding... keep learning....
Thanks🙏 Rajesh Janyani
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
- The logo’s
alt tag
description needs to be improved upon ⚠️; it should state the company’s name.
- The “illustrations/icons” serve no other purpose than to be decorative ⚠️; they add no value. Their
alt tag
should left blank.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- ⚠️ Everything starting from
<div class="col1">
should be wrapped inside thefooter
element.
- ⚠️ The logo and company info inside the
footer
need to be wrapped inside anaddress
element. While each individual information needs to wrapped in ananchor
element.
More Info:📚
- ⚠️ The company directory needs to wrapped in a
nav
element and be built using theunordered list
element to create a single list. You will use the CSS propertycolumn
to style it. Each individual link needs to wrapped in ananchor
element.
More Info:📚
MDN <ul>: The Unordered List element
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
- Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect 💯 on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice ✅ to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord