Design comparison
SolutionDesign
Solution retrospective
Que tal chicos aca mi solucion a este reto Frontendmentor, les agradecería criticas sobre la estructura y funcionalidad de mi código. Espero sus comentarios y muchas gracias.
Hi guys, thre is my solution for this Frontendmentor challenge, and i want to know what do you tihink about my code, structural and funcional. Thanks for all the coments and views!
Community feedback
- @artimysPosted almost 4 years ago
Hi Marcos, nice job at the challenge.
Code suggestions:
- The
bg-hero-desktop.svg
could be abackground-image
in a new container the wraps your.head-bar
andcontent main
containers - I believe for semantics the
<header>
element should not be nested inside the<main>
element.
Design feedback:
- a border radius with a box shadow is missing from the 3 middle content containers
- add a border around the footer social icons
- the left
ul
list in the footer, maybe wrap the font awesome icons in adiv
withdisplay: inline-block
to give it spacing the the lorem ipsum text spans to a 2nd line - and a few to to touch up from your solution report
Keep it up and keep on coding!! 👍
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord