![](https://res.cloudinary.com/dz209s6jk/image/upload/f_auto,q_auto,w_900/Screenshots/szqypkrk4e2cghdkcxb9.jpg)
Huddle landing page with a single introductory using SASS in Flex
Design comparison
Solution retrospective
Here's my finished challenge.
I used SASS for the styling and "flex" for displaying the content.
Any feedback for improvement is appreciated. :)
Happy Coding. :)
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Use company name as the alt attribute value for logos.
-
You should use the
cursor: pointer
property to indicate that the element like a button or a link is clickable. -
Why are the icons buttons? What action do you expect when you click on them? Should they redirect to social media or should they perform some other action?
Using an anchor tag <a> would be more semantically appropriate for those elements, as they should redirect the user to another page. Buttons are generally used for interactive elements that trigger some sort of action or event, while links are used for navigation. So for links to external pages, it is more appropriate to use the anchor tag.
Additionally, you should use the
aria-label
attribute to describe the links if they don't have visible text, this will help screen reader users to understand the purpose of the link. e.g.<a href="#" aria-label="Facebook"><i class="fa-brands fa-facebook-f"></i></a>
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@toshihikotaniPosted almost 2 years ago@MelvinAguilar
Hi, this is nice. Thank you very much. :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord