Submitted about 1 year ago
Huddle landing page with a single introductory section
@msabado1996
Design comparison
SolutionDesign
Solution retrospective
Suggestions and comments and advise for improvements please comment.
Community feedback
- @ChamuMutezvaPosted about 1 year ago
Hi MANUEL
So far so good with your solution. Here are some points to consider.
- use semantic html ahead of elements such as divs. Landmark elements such as header , main and footer should make up your content instead of using a div then give it a class name of header or any of the other names I mentioned above. Read the MDN docs for the benefits of using semantic html.
- the logo usually represents a link to the home page and should therefore be a child of an anchor element. If the the anchor element has an aria-label , then the logo can have an empty alt value.
- alt values for images should contain values that are beneficial to assistive technology users. Words such as
image , logo
are redundant and should be avoided. - the
register
button , should also be an anchor element in my opinion. Look at the main difference between a button and an anchor element, - since you have a
footer
element, the footer icons should also be inside thefooter
element. - the
icons
are not just images but represent social media accounts such as facebook, twitter and instagram. That means that the parent should then be an anchor element. - a css reset like the one by Andy Bell - CSS Reset , should be present in your css
- the font family does not look like the one mentioned in the style guide.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord