Huddle Landing Page with a single introductory section with HTML & CSS

Community feedback

• 

  Luke•220

  @lukebergmannPosted almost 4 years ago

  Hey Abbas,

  This code is looking really great! The others to reply definitely covered a ton! The one thing I would double check it the font-color of the 'register' button. I believe you chose the pink color when it should be the plum color! Other than that, this is looking dope!

  Happy Coding! Luke

  1

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted almost 4 years ago

  @lukebergmann Thanks a lot for the feedback!! I really appreciate it mate! Also thanks for pointing that out. I was wondering if it looks better this way or the original way. Maybe I'll just change it according to the original design. Thanks again! Happy coding! :D

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Abbas Saad! 👋

  Nice to see you complete another challenge! Good work on this one! 👏

  I suggest,

  • Adding overflow-x: hidden to the body to prevent a horizontal scroll bar from appearing in the desktop layout.
  • Allowing the background image to fill up the entire area of the screen (even when the screen size increases) by adding background-size: cover.
  • I think setting actual px or rem values for some of the margins or paddings would be a good idea to keep your design consistent across various screen heights and widths (e.g., there's a bit too much space between things in the Ipad Pro layout, for example).

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted almost 4 years ago

  @ApplePieGiraffe Thanks a lot for the feedback!! I actually pretty much did all of the things that you mentioned but for some reasons, it didn't quite work :') Still, I'll keep practicing until I become like you guys! Thanks for the support!! :D Happy coding!

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Great work. However when the screen below 1065px, it shows a horizontal scrollbar due to static widtht of the introductory. And social icons are shrinking when responsive. Please add this style to .social-media a { width: 40px; height: 40px; display: inline-flex; align-items: center; justify-content: center; } Hope it helps. Happy coding ~ :)

  1

  ---

  

  Abbas Saad•260

  @AbbasSaad27Posted almost 4 years ago

  @MasterDev333 Thanks a lot for the feedback!! I'll definitely look into those things. Also thanks for the code! :D

  0