@correlucas
Posted
Hello Yunus, congratulations for your new solution!
I saw your solution live site and the html markup, there's one thing to improve regarding the markup, you can replace the block wrapping the logo as header or nav if you mKe the logo as link. And improve the general content aspect giving less padding between the logo on top ane the social icons bottom. And use max-width to limit how much the hero image and section can grow.
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/huddle-lp-section-vanilla-css-logo-animation-easter-egg-bem-meb3nl6zF8
Marked as helpful
@yunusemrecinar
Posted
@correlucas Hi, Thanks for your advice I did changed what you said. I think I'm using <header> for logo. Is not it ? And one more thing. You're saying, give less padding between logo and top. I'm assuming this is for mobile version right ?
@correlucas
Posted
@Yunuscinar41 you've used a class as header <div class="header"> not tag
I open it and about 1000px there's a gap between the header and footer, its the same for you?
@yunusemrecinar
Posted
@correlucas Yes, it's same to me. I thought, that will be look nicer but I changed. I changed the tag too. Sorry about that I thought you mean the class one .
@correlucas
Posted
@Yunuscinar41 thats fine, then I'll open again with my computer, I've opened with a tablet with desktop mode and give you ahain a feedback, but anyway are only two details, the solution overall is fine Yunus 👏
