Design comparison
Solution retrospective
is using min-width and min-height a good practice?
Community feedback
- @vanzasetiaPosted almost 2 years ago
Hi! ๐
If you are using
min-width
andmin-height
appropriately, then there is no problem.But, there is no need to set
min-width: 900px
on the<body>
element. It makes the page show a horizontal rule if the browser's window is less than 900px width. So, never setmin-width
to the<body>
.I don't think you need any
min-width
. You only need to usemax-width
to prevent the content from filling the entire page on a very large screen like 2880px for example.One more suggestion I have is to use
aria-label
to provide an accessible name for each social media link. This way, the screen readers know how to pronounce the link.Learn more โ What is an accessible name? - TPGi
I hope this helps. Happy coding!
Marked as helpful1 - @catherineisonlinePosted almost 2 years ago
Nice! ๐๐ป
I would also add some transitions for active states (when colors change on hover). It creates more interactivity and makes the project looks cooler. Active states can be done on buttons, links, titles which act like links or anything else, you choose.
You can read more about it here, in case you havenโt done much of it:โจhttps://www.w3schools.com/css/css3_transitions.asp
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL ๐คฉ
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord