Responsive landing page using CSS Flexbox and Grid
Design comparison
Solution retrospective
Help me to improve the solution code with your feedback
-
Should i refactoring the code to shorten it?
-
The documents division seems more organized?
-
What do you suggest i do to have a better code?
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- A logo is often a crucial part of a website's branding and identity, and it may contain important information for the user. you should use the company name as the
alt
attribute value. The word "logo" is not necessary.
- You should use the
aria-label
attribute to describe the links if they don't have visible text, this will help screen reader users to understand the purpose of the link.
e.g.
<a href="#" aria-label="Facebook"><i class="fab fa-facebook-f"></i></a>
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@michel-moreiraPosted almost 2 years ago@MelvinAguilar I really liked your suggestion and applied it. Thank you very much for the support and feedback, it was very useful and contributed to my learning!
Happy coding and peace!
1 - A logo is often a crucial part of a website's branding and identity, and it may contain important information for the user. you should use the company name as the
- @SvprncePosted almost 2 years ago
Brother Can you explain that Font Property you used ? I mean that what are the property used in that simple font property. And importantly that your used 2 rem seperated by { / }. Check below Screenshot
0@michel-moreiraPosted almost 2 years ago@Svprnce Greeting! How you doing? I've used a shorthand to the property font. You can find more about on: Mozilla Developer
Basically the order is:
font: font-weight font-size / line-heigth font-family;
0@SvprncePosted almost 2 years ago@michel-moreira My doubt was cleared brother โบ. Thank you ๐
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord