Design comparison
Solution retrospective
Hi !
It was a difficult challenge for me. Please let me a feedback to improve myself and my code.
Regards, Steph
Community feedback
- @HassiaiPosted almost 2 years ago
For the left and right side spaces on the page, give the header, the main and the footer a max-width of 1440px, a width of 80% and margin: 0 auto. instead of giving the body a padding value
header,main,footer{ max-width: 1440px; width: 80%; margin: 0 auto; }
give the main img a width of 40% and .main-txt a width of 55% in the media query for the mobile design give the main img and .main-txt a width of 100% . To make the image responsive, give the img a max-width of 100%
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@Fanou59Posted almost 2 years ago@Hassiai Thank you for your feedback :)
What do you think of this new version ?
Regards, steph
1@HassiaiPosted almost 2 years ago@Fanou59 am soo sorry i flipped the value of the width, the main> img should get 55% and the .main-txt should get a 40%. am very sorry again. The new version is awesome please correct my mistake. Hope am helpful
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord