Alamin• 2,000
@CodePapa360
Posted
Hi Ahmed Mangood👋 Great job on completing this challenge! 🥳
I noticed a few areas where your solution to the challenge could be improved, and wanted to share my suggestions with you.
- Instead of repeating the same font families multiple times in the
html
element, you could specify a singlefont-family
property with a list of fallback fonts. For example:
html {
font-family: 'Fraunces', 'Mochiy Pop One', 'Montserrat', 'Open Sans', 'Poppins', sans-serif;
}
- You could use the
:not()
pseudo-class to simplify the code for thesocial-icons
element. For example:
.social-icons > a:not(:last-of-type) {
margin-right: 10px;
}
- You could use the
rem
unit instead ofpx
for font sizes and other dimensions. This allows the sizes to be more easily scaled based on the root element's font size. For example:
main .content h1 {
font-size: 2.2rem;
}
Overall, this is a very well done solution to the challenge. Great job!
Hope I'm 👍helpful!
Keep up the good work!😊❤️
Marked as helpful
1