Submitted almost 2 years ago
Huddle landing page with single introductory section solution
@ahmed-mangood
Design comparison
SolutionDesign
Community feedback
- @CodeWithAlaminPosted almost 2 years ago
Hi Ahmed Mangood👋 Great job on completing this challenge! 🥳
I noticed a few areas where your solution to the challenge could be improved, and wanted to share my suggestions with you.
- Instead of repeating the same font families multiple times in the
html
element, you could specify a singlefont-family
property with a list of fallback fonts. For example:
html { font-family: 'Fraunces', 'Mochiy Pop One', 'Montserrat', 'Open Sans', 'Poppins', sans-serif; }
- You could use the
:not()
pseudo-class to simplify the code for thesocial-icons
element. For example:
.social-icons > a:not(:last-of-type) { margin-right: 10px; }
- You could use the
rem
unit instead ofpx
for font sizes and other dimensions. This allows the sizes to be more easily scaled based on the root element's font size. For example:
main .content h1 { font-size: 2.2rem; }
Overall, this is a very well done solution to the challenge. Great job!
Hope I'm 👍helpful!
Keep up the good work!😊❤️
Marked as helpful1 - Instead of repeating the same font families multiple times in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord