Huddle Landing Page with react

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 2 years ago

  Any particular reason you've used React for this?! Seems overkill

  Remember when you start writing react you must not let good code practices be left behind like accessible html

  Some improvements needed:

  1. A logo is extremely important content. The most important on this page in fact. It cannot be treated as presentational
  2. You must use landmarks. This challenge clearly has a header main and footer but you've not used them. They cannot go inside each other so you need to remove the wrapping main
  3. If an image is valuable content it must have a proper description. Alt should not include words like "image" or "picture" as the img already has an image role
  4. Social links need an accessible name

  Marked as helpful

  1

  ---

  

  Mirza Monirul Alam•680

  @WebDevMirzaPosted almost 2 years ago

  Hi @grace-snow,

  • Your feedback helps me a lot. 👍 I have applied all the four points that you have recommended. Actually, I treated the whole design as a main which was a wrong approach as there is clearly header, main, and a footer section in the layout.
  • When I removed presentation and used alt instead, accessibility issues solved as well that I have before. 🤩

  Thanks.

  0