Landing Page using grid

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Add aria-label attribute aria-label=" " to the <a> of the social media icons to fix the error and accessibility issue. The value of the aria-label is the description of the image. For more aria-label click here

  For the left and right-sides space of the page, give the header, main and footer a max-width of 1440px and width of 80% and margin: 0 auto.

  header, main, footer{
  max-width: 1440px;
  width: 80% ;
  margin: 0 auto;
  }
  

  There is no need to give the body a height value in the media query. Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1
• 

  LEO•170

  @Leo-LCPosted almost 2 years ago

  I can see the background at all times on my side. Can you be more specific ? Maybe with a screenshot or details as to in which situation you see it not appearing ?

  0

  ---

  

  Mahmoud Elgendy•220

  @mahmoudelgendy1Posted almost 2 years ago

  @Leo-LC When I uploaded this project, it didn't show the background image (in the screenshot of frontend mentor), so i generated a new screenshot and it showed the background image but i didn't know why it doesn't work first time

  0