Design comparison
Solution retrospective
I would like to get criticism and know what I am doing wrong so that I can improve it in the future.
Community feedback
- @HassiaiPosted almost 2 years ago
For the left and right side space of the page, give the main a max-width of 1440px, width of 80% and margin: 0 auto.
main{ max-width: 1440px; width:80%: margin:0 auto; }
Add a width of 100% to .center-right in the media query
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- A logo may not be considered as a decoration in HTML because it is often a crucial part of a website's branding and identity, and it may contain important information for the user. you should use the company name as the
alt
attribute value. Use the <img> tag instead of the background properties.
-
Social media icons, which are often used to link to a company's social media profiles, should typically be anchor elements because anchor elements allows users to easily click on the icon and be taken directly to the company's social media profile page. This makes it easy for users to connect with the company on social media
Additionally, you should use the
aria-label
attribute to describe the links if they don't have visible text, this will help screen reader users to understand the purpose of the link.
e.g.
<a href="#" aria-label="Facebook"><i class="fa-brands fa-facebook-f"></i></a>
I hope you find it useful! ๐
Happy coding!
0 - A logo may not be considered as a decoration in HTML because it is often a crucial part of a website's branding and identity, and it may contain important information for the user. you should use the company name as the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord