Submitted over 2 years ago
Huddle landing page with a single introductory section
@michelgx21
Design comparison
SolutionDesign
Solution retrospective
all feedback is welcome
Community feedback
- @youtubbehPosted over 2 years ago
Hi Michel, I would suggest a couple of things:
- Be sure to add some padding to your <main> tag because your content is right on the border, which makes for not such a good user experience.
- You have an accessibility issue with the links on the attribution footer. The color doesn't contrast well with the background, so people can't read the text well. You can just add a color property to your <a> 's on CSS
- You're using 2 divs with 2 different id's to structure sections 1 and 2. There's a better way to do this, using the <section> tag with a class or id. And you can ditch the divs. Why is this better? It's good practice to use semantic tags whenever possible, as these tags tell the browser what the content is about, and also is easier to read by collaborator coders (example: <section>, <footer>, <main>, <header>, etc. instead of divs). You can apply this concept to other divs you have, when possible.
- The social media logos are not centered in their circles. For a better aesthetic, I would either center them or remove their circle borders (much easier).
Nice form btw!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord