@pikapikamart
Posted
First, great that it's up and running now!
Layout in desktop looks really good, responds well to screen size and the mobile layout looks really good as well.
Some suggestions are:
- On the website logo
img
, lose the word "logo" and just usealt="huddle"
. Avoid words that relates to "graphic" such as those, sinceimg
is an image and you don't need to describe them as one. - The same goes for the
img
on the hero-section. But on this one, it would be better to bealt=""
since the image is just a vector-illustration, it just serves as an decoration. - I would use anchor tag
a
on theregister
since it doesn't look like it is a control for a modal/popup, more likely an "link" to register page. - For the
a
that wraps the social media links, it should havearia-label
and the value will be the name of the social media. For example, thea
tag that wraps facebook will be:
<a class="social" href="#" aria-label="facebook">
<i class="fab fa-facebook-f"></i> # the aria-hidden is not needed in here
</a>
Or another approach would be to have a sr-only
text inside the a
tag. This just result on the same output, but I saw what Grace said that, aria-label
is not translatable, I still don't know what it means , need to search for it :>, but the other approach will look like:
<a class="social" href="#">
<span class="sr-only"> facebook </span>
<i class="fab fa-facebook-f" ></i>
</a>
The styling for the sr-only
is:
.sr-only {
border: 0;
clip: rect(0 0 0 0);
height: 1px;
margin: -1px;
overflow: hidden;
padding: 0;
position: absolute;
width: 1px;
}
Copy that one out, you will used that a lot:>
Again, great job on this one.
Marked as helpful
@giaonnq1401
Posted
@pikamart Thanks a lot! There're so many things for me to learn and experience for the next challenge. Have a nice day :>