Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Huddle landing page with a single introduction section

@giaonnq1401


Design comparison


SolutionDesign

Solution retrospective


Hi Guys, this challenge makes my aesthetic look a lot different, it's really beautiful. If you have any opinion about my challenge, please comment, any feedback is welcome. Thank you so much <3

Community feedback

@pikapikamart

Posted

First, great that it's up and running now!

Layout in desktop looks really good, responds well to screen size and the mobile layout looks really good as well.

Some suggestions are:

  • On the website logo img, lose the word "logo" and just use alt="huddle". Avoid words that relates to "graphic" such as those, since img is an image and you don't need to describe them as one.
  • The same goes for the img on the hero-section. But on this one, it would be better to be alt="" since the image is just a vector-illustration, it just serves as an decoration.
  • I would use anchor tag a on the register since it doesn't look like it is a control for a modal/popup, more likely an "link" to register page.
  • For the a that wraps the social media links, it should have aria-label and the value will be the name of the social media. For example, the a tag that wraps facebook will be:
<a class="social" href="#" aria-label="facebook">
  <i class="fab fa-facebook-f"></i>  # the aria-hidden is not needed in here
</a>

Or another approach would be to have a sr-only text inside the a tag. This just result on the same output, but I saw what Grace said that, aria-label is not translatable, I still don't know what it means , need to search for it :>, but the other approach will look like:

<a class="social" href="#">
  <span class="sr-only"> facebook </span>
  <i class="fab fa-facebook-f" ></i>
</a>

The styling for the sr-only is:

.sr-only {
  border: 0;
  clip: rect(0 0 0 0);
  height: 1px;
  margin: -1px;
  overflow: hidden;
  padding: 0;
  position: absolute;
  width: 1px;
}

Copy that one out, you will used that a lot:>

Again, great job on this one.

Marked as helpful

0

@giaonnq1401

Posted

@pikamart Thanks a lot! There're so many things for me to learn and experience for the next challenge. Have a nice day :>

0

@pikapikamart

Posted

Hey, the page won't load on this one. Check on it and resubmit again :>

0

@giaonnq1401

Posted

@pikamart oh, my mistake. I just updated again. It would be happy if you comeback and review my challenge. Thank you.

0

@pikapikamart

Posted

@giaonnq1401 Sure :>

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord