Huddle landing page

Community feedback

• 

  Amon•2,560

  @A-amonPosted over 3 years ago

  Hello! Great work~

  I have a few suggestions:

  1. Setting background-size:100% on mobile size will solve your question.

  2. Removing the background-position makes it look closer to design by sticking the image to the top.

  3. Wrap the social media icons in a tags respectively because they are usually linked to the social media pages.

  4. I like how you separate the header, content and footer. You can try using the header tag and main tag for #header and .content respectively.

  5. Use padding instead of margin for spacing inside elements. For example, body, #header and .container. (But this is just my opinion. Not really sure how others do it~ :) )

  6. Have a good alt text that describes the image.

  7. Use button tag instead of div for buttons.

  8. I wonder if the margin:10px in body tag is necessary.

  Marked as helpful

  1

  ---

  

  Hdev•215

  @hemanuelaPosted over 3 years ago

  @A-amon Wow! Tks! I will check all suggestions. You helped me a lot!

  0

  

  Amon•2,560

  @A-amonPosted over 3 years ago

  @hemanuela Glad to help!

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  As you can see in the screenshot comparison your elements are sized to large in the desktop mode also at the point of your mobile to desktop break-point the desktop layout is too large for the screen width and ends up half off the side of the browser window

  0

  ---

  

  Hdev•215

  @hemanuelaPosted over 3 years ago

  @palgramming Tks, but my solution doesn't look like the screenshot. I don't know why. Have you visited the preview site?

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @hemanuela Yes I did visit your solution

  0