huddle landing page

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi Olawalefaruk

  So far so good with your solution, here is some observations from my side

  HTML

  • it's a good thing that you are making use of semantic html such as the main, header, buttons and headings. I will talk about some of them below regarding best practices, accessibility among other things.
  • Heading elements should follow a sequential order , with the h1 being the first heading element and for best practice, there should be only one h1 heading element. MDN has a good explanation on heading elements and is generally regarded as the best resource.
  • the alt value should always be present in a site and if the image is for decorative purposes then an empty value should be used , otherwise the value should be descriptive to allow users understand the message in the image for the benefit of assistive technology users of when the image fails to load.
  • buttons and anchor elements have some difference in use , an anchor element is used when navigating to other section or other pages whereas the buttons should be used in cases where the effect is to open a menu, dialog (click events). Having said that , the get started for free button seems to be for navigating to another section or page
  • an input element should have a label associated with
  • the social div images are meant to be links to the related social icons , hence they should be treated as links .

  CSS

  • start mobile first when styling
  • you are right to use rems for font-sizes, your current font-sizes are way too too small . In general , your font-sizes should be a minimum of 1 rem.
  • look for one of the Modern css reset stylesheets, one main one is the one by Andy Bell.

  Marked as helpful

  0

  ---

  

  Faruk Olawale•300

  @OlawalefarukPosted over 1 year ago

  Thank you very much boss@ChamuMutezva

  0