Design comparison
Solution retrospective
Feel free to give me feedback!
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on this one. The layout in desktop is good and that loading animation is good, a bit of animation touch right. The mobile layout is good as well.
Some suggestions would be:
-
Using hierarchical header tags. You started at
h2
on the main title, where it should have beenh1
. Following order from h1-h6 is good. Also you usedh1
on the two quantity title which should not be the case, since we should only use 1h1
per page. -
It is not a good practice to remove the outline on the elements. Those outlines serves as a visual key to know where a user is currently in. If you were to remove it, make sure to add some
:focus
state on those, either box-shadow or anything that will state where they are . -
Social media links should ne wrapped inside their respective
a
tags. Since they are links right, it is much better for them to be nested ina
tags.
Just those, but still, you did a good job here^
0@thisisharshjainPosted over 3 years agoHey @pikamart, Thanks a lot for checking out my solution and pointing out the mistakes i did. I fixed them and updated the solution page ✌ Have a great day!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord